Cleanup kernel launch code #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasfaingnaert
force-pushed
the
tf/cleanup-launch
branch
from
a8b4b9e
to
367644f
Compare
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 41.25% 40.85% -0.40%
==========================================
Files 10 10
Lines 446 443 -3
==========================================
- Hits 184 181 -3
Misses 262 262
Continue to review full report at Codecov.
|
maleadt
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess that when I started working on GEMMs,
CUDA.@cudadidn't have thelaunchargument yet, or I just missed it.In any case, the kernel launch code can be cleaned up now, so we don't duplicate logic from CUDA.jl.